administrator/blaise
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(native): ARC for managed-type static array element assignment

Browse source 
Extends the ARC element-assignment pattern to static arrays: when
assigning to A[I] where the element type is string or class, emit
AddRef(new)/Release(old) before the store, matching the QBE backend
and the dynarray path added in the previous commit.
This commit is contained in:
Graeme Geldenhuys 2026-06-10 08:30:27 +01:00
parent 0317a3b454
commit 4eaec15e67
1 changed files with 26 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
compiler/src/main/pascal/blaise.codegen.native.x86_64.pas
View file

@ -8643,26 +8643,42 @@ begin
(SSA.ResolvedArrayType.Kind <> tyStaticArray) then
raise ENativeCodeGenError.Create(
'native backend: static subscript assign on non-static-array');
{ Compute element address: base + (Index - LowBound) * ElemSize }
{ Evaluate value first, push to preserve across address computation. }
DAElemType := TStaticArrayTypeDesc(SSA.ResolvedArrayType).ElementType;
Self.EmitExprToEax(SSA.ValueExpr);
Self.Emit(#9'pushq %rax');
{ Compute index offset into %rax. }
Self.EmitExprToEax(SSA.IndexExpr);
if TStaticArrayTypeDesc(SSA.ResolvedArrayType).LowBound <> 0 then
Self.Emit(Format(#9'subq $%d, %%rax',
[TStaticArrayTypeDesc(SSA.ResolvedArrayType).LowBound]));
Self.Emit(Format(#9'imulq $%d, %%rax',
[TStaticArrayTypeDesc(SSA.ResolvedArrayType).ElementType.RawSize()]));
{ Base address into %rcx. }
Self.Emit(Format(#9'imulq $%d, %%rax', [DAElemType.RawSize()]));
if Self.IsLocal(SSA.ArrayName) then
Self.Emit(Format(#9'leaq %s, %%rcx', [Self.VarOperand(SSA.ArrayName)]))
else
Self.Emit(Format(#9'leaq %s(%%rip), %%rcx', [SSA.ArrayName]));
Self.Emit(#9'addq %rcx, %rax'); { %rax = element address }
Self.Emit(#9'movq %rax, %rcx'); { save element address to %rcx }
Self.Emit(#9'popq %rax'); { restore value }
Self.EmitStoreVar('(%rcx)', TStaticArrayTypeDesc(SSA.ResolvedArrayType).ElementType);
Self.Emit(#9'addq %rcx, %rax');
Self.Emit(#9'movq %rax, %rcx');
if DAElemType.Kind = tyString then
begin
Self.Emit(#9'pushq %rcx');
Self.Emit(#9'movq 8(%rsp), %rdi');
Self.Emit(#9'callq _StringAddRef');
Self.Emit(#9'movq (%rsp), %rcx');
Self.Emit(#9'movq (%rcx), %rdi');
Self.Emit(#9'callq _StringRelease');
Self.Emit(#9'popq %rcx');
end
else if DAElemType.Kind = tyClass then
begin
Self.Emit(#9'pushq %rcx');
Self.Emit(#9'movq 8(%rsp), %rdi');
Self.Emit(#9'callq _ClassAddRef');
Self.Emit(#9'movq (%rsp), %rcx');
Self.Emit(#9'movq (%rcx), %rdi');
Self.Emit(#9'callq _ClassRelease');
Self.Emit(#9'popq %rcx');
end;
Self.Emit(#9'popq %rax');
Self.EmitStoreVar('(%rcx)', DAElemType);
Exit;
end;